Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added XDG support #157

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Added XDG support #157

merged 2 commits into from
Feb 6, 2025

Conversation

czaplicki
Copy link
Contributor

solving issue #150

renamed readPrefsFromHome -> readUserPrefs
made readUserPrefs look for $XDG_CONFIG_HOME, check if it exists
and if so, readPrefs from it instead of $HOME/.haskeline.
If it doesen't exist, readPref from $HOME/.haskeline.

@czaplicki
Added XDG support
73c87e3 
renamed readPrefsFromHome -> readUserPrefs
made readUserPrefs look for $XDG_CONFIG_HOME, check if it exists
and if so, readPrefs from it instead of $HOME/.haskline.
If it doesen't exist, readPref from $HOME/.haskline.
MrQubo
MrQubo suggested changes May 3, 2021
View reviewed changes
System/Console/Haskeline/InputT.hs Outdated Show resolved Hide resolved
@Lubsch
Copy link

Lubsch commented Oct 30, 2023

Sorry for basically just +1-ing this, but what has been blocking this from getting merged? I would really appreciate this feature.

@tjakway
Copy link

tjakway commented Oct 30, 2023

Sorry for basically just +1-ing this, but what has been blocking this from getting merged? I would really appreciate this feature.

Same here. And if there are any blockers I'd be willing to do the work to get this merged.

@yzhou216
Copy link

Is there any update on this?

@qguv
Copy link

qguv commented Feb 4, 2025

This is one of the few remaining tools that doesn't support XDG_CONFIG_HOME. Any chance this approved PR can be merged soon?

@qguv
Copy link

qguv commented Feb 4, 2025

@athas, I see you volunteered to maintain this package once it was moved to the haskell org, perhaps you could press the green button for us? 😄

@athas
Copy link
Collaborator

athas commented Feb 4, 2025

I would, but I am not a maintainer. I am still willing to serve in that role if some GitHub Sultan is able to grant me the role.

@jokesper
Copy link

jokesper commented Feb 4, 2025

I think @bgamari should have maintainer rights, since he merged the last commit into master.

@MrQubo
Copy link

MrQubo commented Feb 5, 2025 •
edited
Loading

This PR should also update README.

haskeline/README.md

Line 21 in 073eca6

- A `~/.haskeline` file allows customization of [preferences](https://github.com/judah/haskeline/wiki/UserPreferences) and [custom key bindings](https://github.com/judah/haskeline/wiki/CustomKeyBindings).

Wiki needs to be updated as well, but I don't think GitHub allows adding wiki changes as part of PR?

@bgamari
Copy link
Collaborator

bgamari commented Feb 5, 2025

In principle I would welcome @athas helping with maintenance. Unfortunately, I don't actually have the permissions to make this happen myself. @Bodigrim, perhaps you could help here?

@Bodigrim
Copy link
Collaborator

Bodigrim commented Feb 5, 2025

@athas give it a try now?

@bgamari could you please add https://hackage.haskell.org/user/TroelsHenriksen to https://hackage.haskell.org/package/haskeline/maintainers/edit ?

@bgamari
Copy link
Collaborator

bgamari commented Feb 5, 2025 •
edited
Loading

@bgamari could you please add https://hackage.haskell.org/user/TroelsHenriksen to https://hackage.haskell.org/package/haskeline/maintainers/edit ?

Done.

@athas athas merged commit c469e92 into haskell:master Feb 6, 2025
@athas
Copy link
Collaborator

athas commented Feb 6, 2025

I will take a few days to familiarise myself with haskeline (and update docs etc as necessary) before making a new release.

@qguv
Copy link

qguv commented Feb 6, 2025

Thanks a lot, everyone!!

@athas athas mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrQubo MrQubo MrQubo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@czaplicki @Lubsch @tjakway @yzhou216 @qguv @athas @jokesper @MrQubo @bgamari @Bodigrim